Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Disable thumbnail generation in napari layer as it is fragile and not used #1171

Merged
merged 2 commits into from
Aug 1, 2024
Merged

chore: Disable thumbnail generation in napari layer as it is fragile and not used #1171

merged 2 commits into from
Aug 1, 2024

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Aug 1, 2024 •
edited by coderabbitai bot
Loading

This PR uses a private API, but should not be fragile as change name of function will only enable again thumbnail generation.

Summary by CodeRabbit

  • New Features
    • Enhanced control over thumbnail management in the image processing workflow by disabling automatic updates for thumbnails in specific image layers.
  • Bug Fixes
    • Resolved issues related to unintended thumbnail updates, improving the overall user experience when working with images.

@Czaki Czaki added this to the 0.15.4 milestone Aug 1, 2024
@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Aug 1, 2024 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 1, 2024 •
edited
Loading

Walkthrough

This update introduces a private class, _NapariImage, that extends the functionality of NapariImage by disabling thumbnail updates during layer preparation. The core functionality is modified to ensure that layers created do not automatically update their thumbnails, allowing for better control over image processing workflows.

Changes

Files Change Summary
package/PartSeg/common_gui/napari_image_view.py Introduced _NapariImage class to replace NapariImage, overriding thumbnail update functionality in the _update_thumbnail method.

Poem

In a world of images, bright and clear,
A rabbit hops in, spreading cheer.
With thumbnails now taking a break,
Control we gain, for processing's sake.
So here's to the layers, both bold and new,
🐇✨ A leap towards clarity, just for you!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

sourcery-ai[bot]
sourcery-ai bot reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Czaki Czaki changed the title Disable thubnail generation in napari layer as it is fragile and not used chore: Disable thumbnail generation in napari layer as it is fragile and not used Aug 1, 2024
coderabbitai[bot]
coderabbitai bot reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 488f52d and 585a01e.

Files selected for processing (1)
  • package/PartSeg/common_gui/napari_image_view.py (2 hunks)
Additional comments not posted (2)
package/PartSeg/common_gui/napari_image_view.py (2)

63-66: LGTM!

The _NapariImage class correctly inherits from NapariImage and effectively disables the thumbnail update with the overridden _update_thumbnail method.

Line range hint 1081-1089:
LGTM!

The _prepare_layers function now correctly uses _NapariImage to disable thumbnail updates. This aligns with the PR objective.

@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (488f52d) to head (585a01e).
Report is 45 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1171   +/-   ##
========================================
  Coverage    93.09%   93.09%           
========================================
  Files          209      209           
  Lines        32881    32883    +2     
========================================
+ Hits         30609    30611    +2     
  Misses        2272     2272

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki Czaki merged commit be273fa into develop Aug 1, 2024
55 of 59 checks passed
@Czaki Czaki deleted the limit_contrast_limits_to_dtype branch August 1, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.4
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki